search

packer-community / winrmcp

Copy files to a remote host using WinRM
MIT License
58 stars 31 forks source link

winrm.DefaultParameters is no longer a function #13

Closed connyay closed 8 years ago

connyay commented 8 years ago

Looks like a breaking change was made via https://github.com/masterzen/winrm/pull/44

dylanmei commented 8 years ago

What an unfortunate upstream change. Do you feel that not mutating the new winrm.DefaultProperties variable is safer?

params := winrm.NewParameters(
  winrm.DefaultParameters.Timeout,
  winrm.DefaultParameters.Locale,
  winrm.DefaultParameters.EnvelopeSize)
connyay commented 8 years ago

it is a bit unfortunate 😞

I think not mutating is a good idea - updated.

dylanmei commented 8 years ago

Fantastic, thanks!