search

packer-community / winrmcp

Copy files to a remote host using WinRM
MIT License
59 stars 31 forks source link

Fix Unit tests for parseEndpoint #26

Closed grubernaut closed 7 years ago

grubernaut commented 7 years ago

~~Replaces masterzen/winrm with grubernaut/winrm which maintains upstream API functionality, without requiring an LGPL license through the masterzen/xmlpath dependency.~~

Also fixes the endpoint tests from the breaking change made to the parseEndpoint() function.

$ go test -v ./winrmcp
=== RUN   Test_parsing_an_addr_to_a_winrm_endpoint
--- PASS: Test_parsing_an_addr_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_an_addr_without_a_port_to_a_winrm_endpoint
--- PASS: Test_parsing_an_addr_without_a_port_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_a_hostname_to_a_winrm_endpoint
--- PASS: Test_parsing_a_hostname_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_a_hostname_without_a_port_to_a_winrm_endpoint
--- PASS: Test_parsing_a_hostname_without_a_port_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_an_ipv6_addr_to_a_winrm_endpoint
--- PASS: Test_parsing_an_ipv6_addr_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_an_ipv6_addr_without_a_port_to_a_winrm_endpoint
--- PASS: Test_parsing_an_ipv6_addr_without_a_port_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_an_empty_addr_to_a_winrm_endpoint
--- PASS: Test_parsing_an_empty_addr_to_a_winrm_endpoint (0.00s)
=== RUN   Test_parsing_an_addr_with_a_bad_port
--- PASS: Test_parsing_an_addr_with_a_bad_port (0.00s)
PASS
ok      github.com/packer-community/winrmcp/winrmcp     0.003s

Updated: The upstream library masterzen/winrm has been updated to remove LGPL dependencies, and the fork grubernaut/winrm is no longer needed. This changeset now, solely updates the endpoint tests for the breaking change that was made to the parseEndpoint() function.

dylanmei commented 7 years ago

Great, thanks for the update.