packetcap / go-pcap

Packet capture library and tools in native go
Apache License 2.0
23 stars 5 forks source link

Updated to gopacket/gopacket #53

Closed amarcum closed 4 months ago

amarcum commented 4 months ago

Updated to the maintained gopacket/gopacket instead of google/gopacket Updated minimum go version to match gopacket/gopacket Added a really simple unit test

deitch commented 4 months ago

This is great, thank you. The one you switched to is a fork of the original, so it should work well. If CI passes, I am comfortable with it. Any issues, we always can fix them.

deitch commented 4 months ago

CI is displeased.

amarcum commented 4 months ago

Hopefully that one liner makes the CI happy again! It took a while, but I have also figured out (through way too much trial and error!) how to automatically increment version tags, create a release page in GitHub, and upload a few OS/Platform combos. It might be a worth while update to the existing GitHub Actions file. It also might be good to squash the many attempts to get it working on a PR ;) This is what the releases page would look like: https://github.com/amarcum/go-pcap/releases This is the only relivant change between this PR and the updated GitHub Actions: https://github.com/amarcum/go-pcap/blob/master/.github/workflows/main.yml

deitch commented 4 months ago

Sure, I like the idea of automatic releases on tags. It should be its own file, which makes it much easier to make the whole workflow dependent on tags.

Let's get the CI here happy first, though, then we can do a separate PR.

deitch commented 4 months ago

Looks like that still didn't get it. 🤷‍♂️

amarcum commented 4 months ago

It might help if we don't try to lint all dependencies in go/pkg/mod... That was not so smart of me... This only showed up because we ran the test in a docker container with the go/pkg/mod directory locally mounted in our github.workspace directory which is also the top level of our code... oops.

amarcum commented 4 months ago

Grr... New version of Go requires new linter...

deitch commented 4 months ago

CI is clean! Huzzah! Are you ready to go with this @amarcum ?

amarcum commented 4 months ago

Yup, let's merge!

deitch commented 4 months ago

Done. Thanks, Alex!