search

packetchaos / navi

A Command-line tool which leverages the Tenable.io API to reduce the time it takes to get information that is common during remediation or a troubleshooting event
GNU General Public License v3.0
72 stars 26 forks source link

migrate AWS tags to t.io fails when AWS tag values are greater then 50 chars. #24

Closed jplonie closed 2 years ago

jplonie commented 2 years ago

When syncing tags from aws to t.io, it will fail if the tag value is greater than 50 chars as t.io limit on tag values is 50.

packetchaos commented 2 years ago

Thank you for the insight. I will put a fix in. Do you have any suggestions other than submitting the tags with the first 50 characters?

jplonie commented 2 years ago

As is always the case, I also found a condition afterwards, in which AWS will allow a tab char which T.IO will also not accept, not sure if there is a documented list of valid input for tags in T.IO but if so, it would be worth checking for them in Navi, otherwise its likely to be a game of wack a mole.

On Sat, 2 Apr 2022 at 2:22 am, Casey Reid @.***> wrote:

Thank you for the insight. I will put a fix in. Do you have any suggestions other than submitting the tags with the first 50 characters?

— Reply to this email directly, view it on GitHub https://github.com/packetchaos/navi/issues/24#issuecomment-1086032756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGFHY673ZQL3YYTPAIUHYTVC4ICTANCNFSM5SDMYB7A . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards, JP

packetchaos commented 2 years ago

Right now, I'm working with the product team at Tenable to see if they can change the character limit. I will also look for other miss-alignments between AWS tags and Tenable.io tags. Once I get a good handle on what the go forward strategy is I will put in a fix.

I'm doing some more testing next week on edge cases. So if you find anything else odd, please let me know.

packetchaos commented 2 years ago

Sorry for the long wait. The Tenable Tags have been changed to mirror the length of AWS tags.

However, I was not able to find documentation on AWS accepting "Tab" Characters. This would still be a gap between T.io tags and AWS tags if Tab characters are allowed.

To help me convince our product team to allow "Tab" Characters, can you provide a use-case where that is used?

Any supporting documentation would be helpful as well.