search

packetchaos / navi

A Command-line tool which leverages the Tenable.io API to reduce the time it takes to get information that is common during remediation or a troubleshooting event
GNU General Public License v3.0
72 stars 26 forks source link

Update most excepts to not be bare and formatting #3

Closed jbpratt closed 4 years ago

jbpratt commented 4 years ago

I went through and started catching for specifically KeyError on any accesses of a dictionary. There are still a few bare exceptions left such as Navi/plugins/vuln_export.py:191. This still leads to having quite a bit of "too general" exceptions.

This has nothing to do with the current error I am receiving but I decided to go ahead an add these.

Let me know what you want changed and I'm happy to make updates to this PR.

jbpratt commented 4 years ago

I can close this since it seems you are going through and fixing the bare expects yourself

packetchaos commented 4 years ago

I was going to merge what I didn't catch. But yeah. You can close it. Some of this is old code I haven't cleaned up yet.

Thanks for your help.

On Wed, Dec 11, 2019, 5:58 PM jbpratt notifications@github.com wrote:

I can close this since it seems you are going through and fixing the bare expects yourself

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/packetchaos/Navi/pull/3?email_source=notifications&email_token=AHWPVTISJHW3WFWXK7S6FSTQYGECTA5CNFSM4JY74A42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGVC54I#issuecomment-564801265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWPVTPKXSUEYAXH2Q5B4DLQYGECTANCNFSM4JY74A4Q .