search

packetmonkey / prawn-gmagick

Use GraphcisMagick to load images into a Prawn document
https://github.com/packetmonkey/prawn-gmagick/
13 stars 6 forks source link

Fix extension build #7

Closed jcoleman closed 10 years ago

jcoleman commented 10 years ago

Currently when you attempt to load the installed gem, you get the following error:

/lib/prawn/gmagick.rb:2:in `require_relative': cannot load such file -- ...bundler/gems/prawn-gmagick-181cfeb75911/lib/prawn/gmagick/image (LoadError)

because the extension compiles into lib/image.bundle rather than lib/prawn/gmagick/image.bundle like the Rake task triggered under testing used. This patch standardizes on the default gem installation behavior.

Also eliminates the runtime dependency on rake-compiler.

packetmonkey commented 10 years ago

Thanks a ton! Glad to see this being useful to other people.

packetmonkey commented 10 years ago

Any objection to me cutting v0.0.5 with these changes?

jcoleman commented 10 years ago

Nope! In fact, that would be very helpful.

On Tue, Sep 23, 2014 at 9:54 AM, Evan Sharp notifications@github.com wrote:

Any objection to me cutting v0.0.5 with these changes?

— Reply to this email directly or view it on GitHub https://github.com/packetmonkey/prawn-gmagick/pull/7#issuecomment-56522713 .

packetmonkey commented 10 years ago

0.0.5 is up on rubygems.org, thanks again for the help.

jcoleman commented 10 years ago

Thanks for the quick merge and release.

On Tue, Sep 23, 2014 at 10:52 AM, Evan Sharp notifications@github.com wrote:

0.0.5 is up on rubygems.org, thanks again for the help.

— Reply to this email directly or view it on GitHub https://github.com/packetmonkey/prawn-gmagick/pull/7#issuecomment-56532085 .