search

packit / deployment

Ansible playbooks and scripts for deploying packit-service to OpenShift
MIT License
7 stars 25 forks source link

[Spike-ish] Use kubernetes.core.k8s apply=true by default? #360

Closed jpopelka closed 1 month ago

jpopelka commented 2 years ago

The apply parameter docs says: "apply compares the desired resource definition with the previously supplied resource definition, ignoring properties that are automatically generated. apply works better with Services than force=yes."

I don't quite understand how it's actually different from the default behavior (what are the "properties that are automatically generated"?), but @csomh says it helps when there are properties being removed in the object.

Investigate:

stale[bot] commented 2 years ago

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

stale[bot] commented 1 year ago

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

mfocko commented 1 month ago

What it actually does?

In the simple terms, it makes sure that the definition that is to be deployed matches the one that is already deployed. The difference has already manifested few times, e.g., when @majamassarini was adjusting the /dev/shm for the postgres deployment (bedef2026c84ea00bb329799cc9bef81687fe88d), the change did not get deployed.

Why some tasks already use it and others not?

not sure

Would it make sense to default to apply=true?

Not really. I would definitely avoid it with the “critical” services (e.g., postgres), last time I tried deploying production with apply=true the redeployment of everything caused a small downtime.