search

packit / deployment

Ansible playbooks and scripts for deploying packit-service to OpenShift
MIT License
8 stars 25 forks source link

fix(c9s): enable postgresql module #515

Closed mfocko closed 1 year ago

mfocko commented 1 year ago

With switch to MP+ we have also switched from PostgreSQL 13 to 15, this becomes an issue, since by default the C9S includes version 13 and regular backup is done from the worker.

Since we have multiple worker images, enable the ‹postgresql› module globally to reduce unnecessary copy-pasta into the playbooks for building workers.

Fixes #514

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/393cb5cd65444733aa2c33e91b665fc7

:heavy_check_mark: pre-commit SUCCESS in 1m 30s :heavy_check_mark: deployment-tests SUCCESS in 10m 14s

jpopelka commented 1 year ago

we have multiple worker images

Which do you mean? p-s worker and hardly worker? staging and stable?

Fixes #514

And will it work with server running v13 and pg_dump v15? Because that'll be the situation on packit-prod once we built & import packit-worker:prod from this.

If not, then I think the easiest would be to revert postgres on packit--stg back to v13 and create a card for switching to v15 once everything is deployed to MP+. EDIT: Or move postgres on packit-prod to v15 together with this change.

mfocko commented 1 year ago

Which do you mean? p-s worker and hardly worker? staging and stable?

Packit Service and Hardly, also it feels rather easy to forget about it in 2 places.

And will it work with server running v13 and pg_dump v15? Because that'll be the situation on packit-prod once we built & import packit-worker:prod from this.

I'll spin up a pod on prod to check it, though I have a feeling it's about backward-compatibility issues, so newer server is a problem whereas the newer dump shouldn't be.

If not, then I think the easiest would be to revert postgres on packit--stg back to v13 and create a card for switching to v15 once everything is deployed to MP+. EDIT: Or move postgres on packit-prod to v15 together with this change.

I think it would be easier to just push the postgres to 15 on prod, rather than 15 to 13. Especially since postgres takes care of the “migration”.

mfocko commented 1 year ago

Tested client/pg_dump of newer version than server, works fine.

Worst case would be bumping the postgres image to newer one.

mfocko commented 1 year ago

regate

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/8d235641008f44f9a1b8613c3f858252

:heavy_check_mark: pre-commit SUCCESS in 1m 36s