packit / deployment

Ansible playbooks and scripts for deploying packit-service to OpenShift
MIT License
8 stars 25 forks source link

Expose Sentry related env var in dashboard pod #576

Closed lbarcziova closed 5 months ago

lbarcziova commented 6 months ago

Related to packit/dashboard#410

softwarefactory-project-zuul[bot] commented 6 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/e2ebcb9f6315418896c2bbba85206e72

:heavy_check_mark: pre-commit SUCCESS in 1m 43s :x: deployment-tests RETRY_LIMIT in 7m 31s

softwarefactory-project-zuul[bot] commented 6 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/36891315a2454e0b9ee59e7dc8e79d4c

:heavy_check_mark: pre-commit SUCCESS in 7m 25s :x: deployment-tests RETRY_LIMIT in 7m 26s

lbarcziova commented 6 months ago

I see the PR actually requires 2 env vars, I will have a look into the SENTRY_AUTH_TOKEN.

softwarefactory-project-zuul[bot] commented 6 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/b986d85493a34a658a6511719b575532

:heavy_check_mark: pre-commit SUCCESS in 1m 51s :x: deployment-tests RETRY_LIMIT in 7m 19s

Venefilyn commented 6 months ago

Why isn't DSN enough? 👀

@mfocko SENTRY_AUTH_TOKEN is to provide sourcemaps to Sentry so that it can decipher production builds, as they are minimized

mfocko commented 5 months ago

Correct me if I'm wrong, but based on the docs:

I understand that this token needs to be present during the build, not while deployed, so this is something that should be exposed in the dashboard repo and for the GH Action (that actually builds the images).

Based on the docs from the first link, I have a feeling that it should work correctly by matching the commit SHA to the image.

I'm not very happy about having the org-wide Sentry token present in the deployment, if (hopefully) there's no need for it.

(Based on the discussion with @lbarcziova)

Venefilyn commented 5 months ago

I understand that this token needs to be present during the build, not while deployed

Correct, should only be needed during build

lbarcziova commented 5 months ago

thanks @Venefilyn for confirmation! Then I updated this PR only adding the VITE_SENTRY_DSN and the SENTRY_AUTH_TOKEN will be added in the dashboard repo.

softwarefactory-project-zuul[bot] commented 5 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/b316dca32f1b4548ae9650390e2e2ef1

:heavy_check_mark: pre-commit SUCCESS in 1m 42s :x: deployment-tests RETRY_LIMIT in 7m 16s