search

packit / deployment

Ansible playbooks and scripts for deploying packit-service to OpenShift
MIT License
8 stars 25 forks source link

Configure default_parse_time_macros for packit-service #595

Closed lbarcziova closed 2 months ago

lbarcziova commented 2 months ago

Follow up of packit/packit#2408

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

softwarefactory-project-zuul[bot] commented 2 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/d3ca8792b6b04d0d95052f612bf32a5d

:heavy_check_mark: pre-commit SUCCESS in 1m 37s :x: deployment-tests NODE_FAILURE Node request 200-0007575824 failed in 0s

softwarefactory-project-zuul[bot] commented 2 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/ebb617c154ac43f287a419035cc68f90

:heavy_check_mark: pre-commit SUCCESS in 1m 42s

majamassarini commented 2 months ago

Regarding the failing test, I forgot that you can't access the keys stored in github unless you are working from the packit repo itself (not from a fork). I am not sure if there exist a safe way to workaround this restriction. There exist the pull_request_target trigger which we could use since the action is now in the main branch, but reading the docs:

In order to solve this, we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request.

I don't think it is meant for solving the problem of testing new code.

softwarefactory-project-zuul[bot] commented 2 months ago

Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/47e860161364453287ee31375e42857c

:heavy_check_mark: pre-commit SUCCESS in 1m 44s