search

packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 47 forks source link

Tests require network access #1491

Open csomh opened 2 years ago

csomh commented 2 years ago

Currently trying to set --network none in make check-in-container causes 65 of the tests to fail (both unit and integration tests), which means, that these tests rely on network access, which means they are prone to failing when an external resource accessed through the network changes its behavior (:wave: Bodhi) or showing false results. With network access one never can be sure that mocks are correct in the tests.

Set --network none in make check-in-container and adjust all the tests to pass without network access.

stale[bot] commented 2 years ago

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)

stale[bot] commented 1 year ago

This issue has been marked as stale because it hasn't seen any activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! :unicorn: :rocket: :robot:

(Note: issues labeled with pinned or EPIC are never marked as stale.)