report httpd tracebacks to sentry

packit / packit-service

Packit provided as a service

https://packit.dev

MIT License

37 stars 48 forks source link

report httpd tracebacks to sentry #1697

Closed TomasTomecek closed 1 year ago

TomasTomecek commented 2 years ago

Triggered by https://github.com/packit/packit-service/issues/1696

Since the issue wasn't submitted to sentry and 1) Jan had to ping me 2) and I had to find the traceback in logs (like a caveman)

we should also feed sentry with tracebacks that occur in httpd in our API - we have no clue how many 500s happen in our side AFAIK

TODO:

[ ] make sure packit-service httpd tracebacks are sent to sentry
[ ] do the same for flask in dashboard

mfocko commented 1 year ago

Is this still relevant after Jirka's PR for splunk logs gets merged?

TomasTomecek commented 1 year ago

absolutely: we don't have any alerts on logs right now so we wouldn't know that something is crashing our httpd

majamassarini commented 1 year ago

For an example of exception raised by flask code (which I suppose is ran by httpd) and not logged by sentry see description of packit/packit-service#1958

jpopelka commented 1 year ago

OTOH it seems to work in this case