packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 47 forks source link

Manual trigger should work even if copr build is not completed yet #2265

Closed psss closed 9 months ago

psss commented 9 months ago

Description

I was trying /packit test --identifier full and the jobs were stuck with Queued — RPMs were built successfully.

This seems to be related to the fact that I added the comment before the copr builds were finished. It would be nice to trigger tests automatically once the copr build is completed.

Benefit

User does not have to remember to repeatedly come back to the pull request and check whether the copr build is already done only to schedule manual trigger.

Importance

No response

What is the impacted category (job)?

Testing Farm tests

Workaround

Participation

psss commented 9 months ago

Hm, not sure about the gain/low label. Now tmt is nearing the release and quite a few pull requests are in progress. I have to admit that baby-sitting each one of them to see whether the copr build has been already finished so that I can finally add the trigger comment to get the full test suite executing... getting rid of this I wouldn't call a low gain ;-)

lbarcziova commented 9 months ago

@psss thanks for the explanation, yes, that sounds like it can ease your work quite a lot. Changing it.

psss commented 9 months ago

Thank you!

psss commented 9 months ago

Closing this in favor of a better solution proposed in #2269.