packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 47 forks source link

PACKIT_COMMIT_SHA content differs from the built NVR #2329

Open praiskup opened 7 months ago

praiskup commented 7 months ago

What happened? What is the problem?

The merge_pr_in_ci config is true by default, so the Copr build contains a merge (target) sha in RPMs' NVRs. This sha is not visible anywhere.

The $PACKIT_COMMIT_SHA though contains the bare SHA from git push.

This situation can cause big headaches when the TF test cases attempt to find the corresponding NVRs using PACKIT_COMMIT_SHA.

Workaround is to set merge_pr_in_ci: false.

What did you expect to happen?

The $PACKIT_COMMIT_SHA should contain the same have the built RPMs. No matter the merge_pr_in_ci config.

Example URL(s)

No response

Steps to reproduce

Let the Copr build finish, and compare the RPMs' NVS with `git show` SHA, the hashes are different.

What is the impacted category (job)?

Testing Farm tests

Workaround

Participation

lachmanfrantisek commented 6 months ago

The task is to: