search

packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 46 forks source link

/packit test for a missing build scenario triggering builds for each test job in config #2381

Closed lbarcziova closed 2 months ago

lbarcziova commented 3 months ago

Steps to reproduce:

  1. multiple test jobs in config
  2. no successful Copr builds
  3. /packit test comment

This results in submitting Copr build for each test job separately, resulting in flooding of both Copr and later Testing Farm (once the builds finish and tests are not configured to be run only manually).

This happened for https://github.com/oamg/convert2rhel/pull/1149#issuecomment-2012747884, see multiple Copr builds for that PR+ref and for TF @thrix reported 367 test requests for that PR+ref submitted in a very short period of time.

lbarcziova commented 3 months ago

The easiest (short-term?) fix would be to not make /packit test trigger builds if they are missing (but this would lead to a worse UX).

lachmanfrantisek commented 3 months ago

Let's start the work with a quick team meeting to discuss the possibilities.