Store package config in DB project event

packit / packit-service

Packit provided as a service

https://packit.dev

MIT License

34 stars 48 forks source link

Store package config in DB project event #2394

Closed lbarcziova closed 5 months ago

lbarcziova commented 5 months ago

So that it doesn't have to be obtained via Github API multiple times during the pipeline (e.g. Copr build start, end, Testing farm results)

Fixes #1940

TODO:

[ ] think about cleanup in DB (periodic/pipeline end)
[ ] make sure that now that Event.get_dict() calls get_packages_config(), it doesn't cause obtaining package config in case it is not really needed (e.g. maybe in Event.str)
[ ] test

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/4f1d27d67e9c4b1e82d0f105d012e447

:heavy_check_mark: pre-commit SUCCESS in 2m 19s :heavy_check_mark: packit-service-tests SUCCESS in 2m 51s

mfocko commented 5 months ago

I haven't had a look at the code yet, but I hope this happens »before« the backward-compatibility “hacks” run… cause the way we “inherit” parts of config makes them rather big (you can see that in the endless configs in logs)

lbarcziova commented 5 months ago

I have just realised this might be even more complicated as I noticed the way we dump the config here is different than the one I added, so this is definitely not ready for review yet