packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 48 forks source link

Refactor calling GitProject.get_pr() #2401

Closed lbarcziova closed 5 months ago

lbarcziova commented 5 months ago

Try to use the pull_request_object properties where possible.

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/0acfd97bd5fb44a1bc5bdbfc0fb8660d

:heavy_check_mark: pre-commit SUCCESS in 2m 23s :heavy_check_mark: packit-service-tests SUCCESS in 2m 25s

nforro commented 5 months ago

Won't this cause issues, for example if the target branch of a PR is changed, will it be reflected in StatusReporter.pull_request_object.target_branch?

lbarcziova commented 5 months ago

Won't this cause issues, for example if the target branch of a PR is changed, will it be reflected in StatusReporter.pull_request_object.target_branch?

I don't think it should cause issues, pull_request_object will be initialised per an instance of StatusReporter, so in each handler run this is obtained via API again. Or am I missing something from your question?

softwarefactory-project-zuul[bot] commented 5 months ago

Build failed. https://softwarefactory-project.io/zuul/t/packit-service/buildset/dbf99b175ba24c65852b842807c70997

:heavy_check_mark: pre-commit SUCCESS in 2m 38s :x: packit-service-tests FAILURE in 2m 51s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/adca0f4a03cd4d9889f29ff3129d4928

:heavy_check_mark: pre-commit SUCCESS in 2m 31s :heavy_check_mark: packit-service-tests SUCCESS in 2m 38s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/6e506f83126d4494ae1ba47b0677b1c0

:heavy_check_mark: pre-commit SUCCESS in 2m 17s