packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 46 forks source link

possible race condition: target branch change after PR creation isn't being accounted for #2403

Open lsm5 opened 2 months ago

lsm5 commented 2 months ago

What happened? What is the problem?

See: https://github.com/containers/skopeo/pull/2285 . The PR was initially created with the target branch as main which was later changed to release-1.13. The copr build jobs failed as packit was trying to merge the PR into the upstream main branch as set at the time of PR creation.

I guess the workaround would be to just submit a new PR with the correct branch from the get-go.

What did you expect to happen?

Example URL(s)

See PR in description.

Steps to reproduce

1. create PR
2. change branch
3. retrigger copr jobs (maybe)

What is the impacted category (job)?

Copr builds

Workaround

Participation

lsm5 commented 2 months ago

This seems to be a rare race. Also, https://github.com/containers/skopeo/pull/2296 earlier mentioned in description is not actually an example of this bug as initially suspected, so I removed it from description.

In the PR referenced in description, the branch was changed right away after PR creation https://github.com/containers/skopeo/pull/2285#issuecomment-2057529126 and I'm unable to reproduce that on https://github.com/containers/skopeo/pull/2299 . But maybe that helps to tighten constraints further.