search

packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
37 stars 48 forks source link

Notify maintainers about problems with Bodhi update #2404

Open lachmanfrantisek opened 7 months ago

lachmanfrantisek commented 7 months ago

During discussions with the Gnome maintainers (https://github.com/packit/user/issues/18), a feature request appeared to be able to notify package maintainers about situations that require the maintainer's attention, e.g. negative karma, check failed,... but not about "normal" state like update created or positive karma added.

Alternative ideas:

UX:

Implementation:

lbarcziova commented 7 months ago

Since this might be a generic feature for any Bodhi user, we can think about the possibility of rather doing this in Bodhi itself.

I would probably lean towards this option as it seems more natural to have it there to me.

lachmanfrantisek commented 7 months ago

Asking for opinion/help on Bodhi side: https://github.com/fedora-infra/bodhi/issues/5644

nforro commented 4 months ago
  • There is a topic filtering available, but I am not sure if Bodhi sends negative karma comments to another topic.

Karma updates are still comments, so org.fedoraproject.prod.bodhi.update.comment works, e.g. negative karma for libarchive-3.7.2-5.fc40.

ljavorsk commented 4 months ago

Karma updates are still comments, so org.fedoraproject.prod.bodhi.update.comment works, e.g. negative karma for libarchive-3.7.2-5.fc40.

I didn't get any notification about negative karma on my package, which I didn't even think could happen, so if I hadn't been notified by @lachmanfrantisek I would not have noticed it for quite some time.

An issue_repository config option might be used.

Not sure about this option as some packages don't even configure this option. If you decide to use it, it should be heavily documented in your onboarding docs (so maintainers don't miss it). But I would rather see a regular Bodhi notification email, as I would expect from a regular update I create manually.

kparal commented 4 months ago

I included some examples of where this might cause problems in https://github.com/packit/packit/issues/2342 .

I'd also like to add that even some neutral comments might have content that the maintainer should see, perhaps a question or a concern, when the user is not sure whether it's a bug or not. One option could be if Bodhi implemented a "ping maintainer" checkbox when submitting feedback. Another option is to notify the maintainer (from packit side) also for neutral (and not just negative) comments. Or, for all comments (which is the current Bodhi behavior for manually created updates). Any solution would be an improvement over the current status.

lbarcziova commented 3 months ago

On a related note, in #2503 it was mentioned, that something similar would be useful also for downstream Koji builds - be notified for a failure. The preferred way there was an email.

QuLogic commented 1 month ago

I don't think you should wait to figure out "important" comments on Bodhi, but just get maintainers notified of Bodhi updates entirely first. Later you can wait for https://github.com/fedora-infra/bodhi/issues/5644.

lbarcziova commented 1 month ago

Outcome from our architecture discussion: we will also set up a meeting with someone from CPE to brainstorm how to improve the situation.

lachmanfrantisek commented 1 month ago

I've reached CPE team and was asked to create a ticket to start the discussion -- so, here, it is. There are already a few interesting suggestions if you are interested in this. (Yet to decide what would be the best approach.)

TomasTomecek commented 2 days ago

Just to be clear regarding #2652: I want to receive ALL the info, not just logs for failures.

Once I'm subscribed to a bodhi update for a genuine bugfix, I know when people give it +1/-1 karma and when the update lands. For a maintainer this is important info.