packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 46 forks source link

Release syncing is being retried for all branches when it is not possible to download archive #2447

Open lbarcziova opened 1 week ago

lbarcziova commented 1 week ago

Related code: https://github.com/packit/packit-service/blob/3531669ee87997c0045885c859fa1bb7d43782a3/packit_service/worker/handlers/distgit.py#L443-L457

If it is not possible to download the archive at least for one of the branches, all the branches are being retried no matter whether they ran successfully (probably coming from the assumption that the source being download is the same for all branches). That results in confusing behaviour for branches where the syncing already went successfully - multiple rebases in the created PR.

Reported by @ljavorsk for https://src.fedoraproject.org/rpms/man-pages-l10n/pull-request/23#. In this case the Source is different for the branches (in one incorrectly formatted).