search

packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
34 stars 47 forks source link

List of PRs in dashboard not always the most useful selection #2513

Open mulkieran opened 3 weeks ago

mulkieran commented 3 weeks ago

Description

Example: https://dashboard.packit.dev/projects/github.com/stratis-storage/stratisd

Most of the PRs in this list have already been merged and I'm not necessarily interested in the rpms from those builds. I'm more likely to be interested in a build from an in-progress PR,e.g., https://github.com/stratis-storage/stratisd/pull/3623 . But it is too old to be displayed in the list on the dashboard.

So there should be some way of including in progress PRs, rather than just sorting up numerically.

Benefit

In this case, I wanted to make a build available to my co-worker to start testing with but I had just rebased and the build takes about 30 minutes, so he had to wait, since there was no way to find the previous build.

Importance

This part of the generic problem of not being able to find the Packit build that you want. The best way to solve it would be to make the build you want easy to find generally, so you could say the most recent build from such and such a PR on such and such a platform is located at and just go there. So, what I'm requesting right now may not be worth it if there is a better solution soon to be available.

Workaround

Participation

mulkieran commented 3 weeks ago

This really belong in dashboard, please migrate there, thanks.

Venefilyn commented 2 weeks ago

There isn't much in the API endpoints here to improve this, so I'd say it falls onto the packit-service. The API currently only returns 10 items and that's all there is

@lbarcziova @nforro can the project API endpoints also be improved to reduce load times? Currently it's fetching between so many different tables which seems a bit overkill. One can do follow-up requests if they want more information, which is something that would be greatly improved in the dashboard if more granular endpoints can be made. Ideally project endpoints should also be paginated

So please move it back to packit-service :pray:

lbarcziova commented 2 weeks ago

For the original problem, I think what would make it better is to sort the PRs from the ones with the most recent jobs (e.g. builds), which might not be the simplest to implement. That would be related to packit/packit-service#1882. I agree this is something to work on in packit-service.

@Venefilyn yes you are totally right with that, but I would say we should track that as a separate issue(s).