search

packit / packit-service

Packit provided as a service
https://packit.dev
MIT License
37 stars 48 forks source link

Not possible to waive test results on Bodhi updates created from sidetags #2546

Open nforro opened 1 month ago

nforro commented 1 month ago

It's possible for users to waive failed tests on regular Bodhi updates created by Packit, but it's not possible to do that on updates created from sidetags, only the owner (creator) of a sidetag can do it. Clearly the waiving permissions are set up differently for these two cases, though I haven't been able to find any info on this. This is a blocker for podman releases.

We need to either convince the responsible people/teams to change the permissions, or implement some mechanism that would allow users to ask Packit to waive the results while not allowing misuse.

mfocko commented 1 month ago

Maybe mention the waiving in the role rotation card for the Community Shepherd, also reach out to the Bodhi maintainers.

nforro commented 3 weeks ago

Waiving permissions are handled in waiverdb, however this gets blocked in Bodhi, apparently waiving is considered editing an update. It could be possible to waive the tests directly using waiverdb-cli and overcome this Bodhi obstruction, however it's undocumented and I haven't been able to test it.

nforro commented 3 weeks ago

I spent so much time on this already that I might just take it :slightly_smiling_face:

nforro commented 3 weeks ago

It looks like https://github.com/fedora-infra/bodhi/issues/4014 is the reason why it was implemented in this way - previously, only maintainters of all builds in the sidetag were able to edit the update. But now only sidetag creator can edit it and not the maintainers, so I would say it's a bug. I'll try to propose a PR to fix it.

nforro commented 2 weeks ago

Here is Bodhi PR: https://github.com/fedora-infra/bodhi/pull/5764

nforro commented 1 week ago

The PR has been merged, now we need to wait for the next Bodhi release.