packit / packit.dev

packit.dev website content
https://packit.dev/
MIT License
9 stars 50 forks source link

Check building the website with hugo #447

Closed csomh closed 2 years ago

csomh commented 2 years ago

Make building with hugo part of the PR checks.

Fixes #445.

Signed-off-by: Hunor Csomortáni csomh@redhat.com

softwarefactory-project-zuul[bot] commented 2 years ago

Zuul encountered a syntax error while parsing its configuration in the repo packit/packit.dev on branch main. The error was:

Job hugo not defined

The error appears in the following project stanza:

project: check: jobs:

csomh commented 2 years ago

recheck

csomh commented 2 years ago

recheck

csomh commented 2 years ago

recheck

softwarefactory-project-zuul[bot] commented 2 years ago

Zuul encountered a syntax error while parsing its configuration in the repo packit/packit.dev on branch main. The error was:

Job hugo in packit/packit.dev is not permitted to shadow job hugo in packit/packit-service-zuul

The error appears in the following job stanza:

job: name: hugo parent: base description: Check that the website can be built with hugo pre-run: files/install-hugo.yaml run: files/build-with-hugo.yaml

in "packit/packit.dev/.zuul.yaml@main", line 11, column 3

csomh commented 2 years ago

recheck

softwarefactory-project-zuul[bot] commented 2 years ago

Build failed.

:heavy_check_mark: pre-commit SUCCESS in 1m 25s :x: hugo FAILURE in 1m 21s

softwarefactory-project-zuul[bot] commented 2 years ago

Build failed.

:heavy_check_mark: pre-commit SUCCESS in 1m 15s :x: hugo FAILURE in 1m 00s

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded.

:heavy_check_mark: pre-commit SUCCESS in 1m 14s :heavy_check_mark: hugo SUCCESS in 1m 16s

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded.

:heavy_check_mark: pre-commit SUCCESS in 1m 16s :heavy_check_mark: hugo SUCCESS in 54s

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded (gate pipeline).

:heavy_check_mark: pre-commit SUCCESS in 1m 15s

csomh commented 2 years ago

So it seems, Zuul considers merge conditions to be met, if there was previous approval, even if another review was requested by the same user :-|