packit / packit.dev

packit.dev website content
https://packit.dev/
MIT License
9 stars 50 forks source link

autorelease usage suggestion fallback case seems wrong #477

Closed t184256 closed 2 years ago

t184256 commented 2 years ago

https://packit.dev/docs/faq/#does-packit-work-with-rpmautospec says the following:

Release: %{?autorelease}%{!?autorelease:1{?dist}}

This construct uses autorelease macro if it’s defined, and if it’s not, it sets release to 1{?dist}.

I'm afraid this statement is technically correct, and, if autorelease macro happens to be undefined, the expression evaluates to a literal 1{?dist} =)

It was meant to be %{?autorelease}%{!?autorelease:1%{?dist}} with a % in %{?dist}, right?

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded.

:heavy_check_mark: pre-commit SUCCESS in 1m 20s :heavy_check_mark: hugo SUCCESS in 58s

softwarefactory-project-zuul[bot] commented 2 years ago

Build succeeded (gate pipeline).

:heavy_check_mark: pre-commit SUCCESS in 1m 12s