search

packit / packit.dev

packit.dev website content
https://packit.dev/
MIT License
9 stars 50 forks source link

rpminspect: run using c9s configuration #604

Closed TomasTomecek closed 1 year ago

TomasTomecek commented 1 year ago

This should help everyone who maintains a package in CentOS Stream 9 to get rpminspect feedback upstream using the same configuration as when contributing to c9s.

Fixes #601

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/c972e43dff62492ebc8fbc50bfa4f1cc

:heavy_check_mark: pre-commit SUCCESS in 1m 16s :heavy_check_mark: hugo SUCCESS in 1m 05s

msrb commented 1 year ago

I think this is a good start and I am surprised how easy it looks.

One thing to keep in mind is that rpminspect in Fedora/EPEL is usually old and buggy. The tool is under active development and thus CentOS Stream uses the latest builds from David's COPR: https://copr.fedorainfracloud.org/coprs/dcantrell/rpminspect/

Another thing is that rpminspect compares the new build with the previous build. It can run on just the new build, but then inspections like abidiff won't run as there is no previous build to compare the ABI to.

And the last thing is that maintainers in CentOS Stream can create their own rpminspect.yaml files and store them in dist-git. This local component-specific configuration tweaks the behavior of rpminspect.

But packit doesn't have to support all that.

TomasTomecek commented 1 year ago

Trying the proposal here: https://github.com/packit/ogr/pull/770

Bug report: https://gitlab.com/testing-farm/general/-/issues/65

TomasTomecek commented 1 year ago

I will create a followup card regarding the runs on binary RPMs as we need this to be implemented in testing farm: https://issues.redhat.com/browse/TFT-1574

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/60d2d2e7c20846c3a756873bc4926798

:heavy_check_mark: pre-commit SUCCESS in 1m 11s :heavy_check_mark: hugo SUCCESS in 56s

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/c9692f2ff92c4ca0b0a4cab1e8cac528

:heavy_check_mark: pre-commit SUCCESS in 1m 11s :heavy_check_mark: hugo SUCCESS in 1m 01s

softwarefactory-project-zuul[bot] commented 1 year ago

Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/d40db1fe0b4748668cbd3e504920e85a

:heavy_check_mark: pre-commit SUCCESS in 1m 10s