packit / packit.dev

packit.dev website content
https://packit.dev/
MIT License
9 stars 50 forks source link

packit.yaml/issue_repository is confusing for pull-from-upstream #771

Closed xsuchy closed 10 months ago

xsuchy commented 11 months ago

What happened? What is the problem?

I got this report https://github.com/xsuchy/python-hwdata/issues/5 that pull-from-upstream failed. Put aside why it failed. My problem is that pull-from-upstream failures should not be reported to upstream. In this case, I am the owner of upstream as well. But if upstream would be somebody else, they can be vary angry about it ("why you are bothering us about it, not our business").

This happened because I put issue_repository in packit.yaml in dist-git: https://src.fedoraproject.org/rpms/python-hwdata/blob/rawhide/f/packit.yaml#_3 so one can argue it is my fault and PEBKAC.

But it was nowhere mentioned that dist-git import failures will be reported to issue_repository. And I checked https://packit.dev/docs/configuration/downstream/pull_from_upstream#first-setup https://packit.dev/docs/configuration#issue_repository

I propose:

[ ] amend https://packit.dev/docs/configuration#issue_repository alter last two sentences of the first paragraph to use for issue_repository the downstream repository. Maybe even with an exclamation mark. [ ] alter https://packit.dev/docs/configuration/downstream/pull_from_upstream#first-setup to include in Caution box that you SHOULD NOT use the upstream issue repository there. [ ] amend https://packit.dev/docs/configuration/downstream/pull_from_upstream#example to include downstream issue repository

What did you expect to happen?

No response

Example URL(s)

No response

Steps to reproduce

1.
2.
3.

Workaround

Participation