search

packit / packit.dev

packit.dev website content
https://packit.dev/
MIT License
9 stars 50 forks source link

Enhance description of `sync_changelog` #861

Open nforro opened 6 months ago

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/253dd1669ade46c6b1bce5a2c81df372

:heavy_check_mark: pre-commit SUCCESS in 1m 27s

LecrisUT commented 6 months ago

tmt is using it. The thing is in the %changelog the verison/release numbers are used, so it makes sense to imply that packit does not update version, but I think packit should fail if it is not set to not update the version. Then intent is more specific.

martinhoyer commented 6 months ago

it doesn't really align with the option name

+1. It is a bit misleading, even with the documentation change. Would it be hard to implement sync_changelog=true to not affect the other ways .spec is being processed, like Version, Release updates? Although I'm not sure if it make sense - if a project is making .spec file changes outside of packit, it might as well handle the rest. Perhaps renaming it from sync_changelog to something that implies it's "syncing the whole spec" would be a way?

Why do projects, like tmt, don't use packit for generating changelog?

nforro commented 6 months ago

Perhaps renaming it from sync_changelog to something that implies it's "syncing the whole spec" would be a way?

Yes, this would make the most sense to me. Any ideas how to call it?

nforro commented 6 months ago

Let's discuss this on the next architecture meeting. @martinhoyer in case you would like to participate, let me know and I'll invite you.

martinhoyer commented 6 months ago

Let's discuss this on the next architecture meeting. @martinhoyer in case you would like to participate, let me know and I'll invite you.

Thanks, I probably don't have much to add due to the lack of experience with packit (and in general), so all I have to say is in the above comment. To recap: