search

packit / packit

Upstream project ← → Downstream distribution
https://packit.dev
MIT License
134 stars 84 forks source link

Pull-from-upstream could provide the pkgdiff report within the generated PR #2265

Open ljavorsk opened 5 months ago

ljavorsk commented 5 months ago

Description

Some packages need to be checked for API/ABI compatibility between releases, which could be done using the pkgdiff utility. It is called with 2 arguments: pkgdiff <old_rpm> <new_rpm> (so it needs to be done for every RPM generated by the package.

The report from this tool is stored in very nicely human-readable HTML pages, which could be stored in some location, and the links would be provided within the PR itself.

Benefit

Speeds up the rebase process for package maintainers, as they need to do it manually now.

Importance

Medium. It's not a problem to do it ourselves, but in that case, we need to generate the scratch-build, pkgdiff, and PR ourselves and then it doesn't make very sense to use Packit in that type of package.

Workaround

Participation

lbarcziova commented 5 months ago

hi @ljavorsk ! I can definitely see that users could benefit from this, we have also similar issue #2195.

We would ideally first like to do research (packit/packit-service#2299) on how we could approach the validation more generally (we are also discussing the priorities for next quarter and this is one of the epics we are considering) and let you know once we come up with a plan.