Closed nikitych closed 7 months ago
Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/51088f7327484e5eba82fd07213c3e14
:heavy_check_mark: pre-commit SUCCESS in 2m 18s :heavy_check_mark: specfile-tests-rpm-deps SUCCESS in 1m 11s :heavy_check_mark: specfile-tests-pip-deps SUCCESS in 1m 04s
I'll rewrite PR to add
\n
to the body.
Thanks! Would you also add that case to test_parse
?
There are also a couple of technically errors of missing
\n
here and here. I spent some time but could not figure out how to exploit the non-excluded empty string. So I could fix them as well, but without adding tests.
Good point, but I don't think it matters here, empty lines don't have to be excluded because they can't possibly contain a start of a section. But feel free to replace splitlines()
with split("\n")
(is that the fix you had in mind?).
Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/0a7d01d5fbfd4657b9fc137779544627
:heavy_check_mark: pre-commit SUCCESS in 2m 12s :heavy_check_mark: specfile-tests-rpm-deps SUCCESS in 1m 11s :heavy_check_mark: specfile-tests-pip-deps SUCCESS in 1m 09s
Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/d0cdcd11874b479c99ce699a72857e9a
:heavy_check_mark: pre-commit SUCCESS in 2m 49s
Fixes #360.