packit / specfile

A library for parsing and manipulating RPM spec files
MIT License
23 stars 14 forks source link

Attempt to expand macros before processing conditions #394

Closed nforro closed 2 months ago

nforro commented 2 months ago

Fixes #391.

RELEASE NOTES BEGIN

specfile now tries to expand macros before processing conditions to be able to resolve conditional expressions defined by macros, for example OpenSUSE Tumbleweed defines %ifpython3 macro as %if "%{python_flavor}" == "python3".

RELEASE NOTES END

packit-as-a-service[bot] commented 2 months ago

We were not able to find or create Copr project packit/packit-specfile-394 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=packit-specfile-394 chroots=['epel-8-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private
softwarefactory-project-zuul[bot] commented 2 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/packit-service/buildset/f25a10560b244f74aa1b4013e358a199

:heavy_check_mark: pre-commit SUCCESS in 2m 16s :heavy_check_mark: specfile-tests-rpm-deps SUCCESS in 1m 10s :heavy_check_mark: specfile-tests-pip-deps SUCCESS in 1m 07s

nforro commented 2 months ago

/packit rebuild-failed

softwarefactory-project-zuul[bot] commented 2 months ago

Build succeeded (gate pipeline). https://softwarefactory-project.io/zuul/t/packit-service/buildset/74f7cf3af4ec489d8c928f65609406de

:heavy_check_mark: pre-commit SUCCESS in 2m 10s