Some filenames contain trailing whitespace

packsaddle / ruby-git_diff_parser

Parse `git diff` into patches and lines.

http://packsaddle.org

MIT License

33 stars 14 forks source link

Closed daniel-beard closed 5 years ago

daniel-beard commented 6 years ago

Was not able to look up files using find_patch_by_file because the filename that git_diff_parser picked up had a trailing tab character.
Printing out the patches.files gave the following: ["Dangerfile", "ios/Example/Tests/Test Runners/TestRunner.swift\t"]

sanemat commented 5 years ago

@daniel-beard Could you give me small example? I want to try reproducing.

daniel-beard commented 5 years ago

@sanemat there's a sample diff here: https://github.com/danger/danger/pull/1102 where I fixed the same issue.

sanemat commented 5 years ago

Thank you for your information! I can understand this.