search

packwiz / packwiz-installer-bootstrap

An updater for packwiz-installer.
https://packwiz.infra.link/
MIT License
27 stars 8 forks source link

Fix git access token not being sent in header #8

Closed fuzzyweapon closed 1 year ago

fuzzyweapon commented 1 year ago

I found a bug in latest (v0.0.3). Github API began complaining about needing the tokens to be passed in the request header, which of course, stops packwiz dead in its tracks if you've passed a token in.

Typically, these authorization header tokens are done with "Authorization" as the key name, which worked when I tested it.

In addition, I did some minor cleanup for readability and maintainability.

Last, but not least, I setup the application Gradle plugin to run results in a new build subfolder <gradle_build_dir>/test-project where the default is <project_dir>/build/test-project.

fuzzyweapon commented 1 year ago

Looks like this was packwiz/packwiz-installer#49

Just found it after doing all of this lol. It was a good little exercise though so oh well! Shouldn't hurt to accept it before you move to your maven repo.

comp500 commented 1 year ago

Thanks for the PR! I'll definitely merge this - I ought to have merged the previous PR that also did this but I thought the rewrite would take less time than it has :P

I definitely should push my progress somewhere, hopefully I can get the rewrite finished fairly soon.

fuzzyweapon commented 1 year ago

Yeah. I'd love to see it. I'm getting more invested on working on it more as I've been looking through the code more and more, but I'm a little hesitant because it sounds like you've got big stuff in the works.

On Mon, Mar 6, 2023 at 11:31 AM comp500 @.***> wrote:

Thanks for the PR! I'll definitely merge this - I ought to have merged the previous PR that also did this https://github.com/packwiz/packwiz-installer-bootstrap/pull/5 but I thought the rewrite would take less time than it has :P

I definitely should push my progress somewhere, hopefully I can get the rewrite finished fairly soon.

— Reply to this email directly, view it on GitHub https://github.com/packwiz/packwiz-installer-bootstrap/pull/8#issuecomment-1456831267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJSAF4F2CL5CPSMQV5GLSDW2Y3RLANCNFSM6AAAAAAVQMWKZA . You are receiving this because you authored the thread.Message ID: @.***>

xtexChooser commented 1 month ago

is there any releases or prebuilt binary with this patch available?