search

packwiz / packwiz-installer

An installer for packwiz modpacks, with automatic auto-updating and optional mods! Works well with MultiMC and on servers.
https://packwiz.infra.link/
MIT License
46 stars 21 forks source link

Replace SpaceSafeURI with HttpUrl #32

Closed geferon closed 2 years ago

geferon commented 2 years ago

I believe I asked you some time ago about the OkHttp implementation you were doing, and saw you were halfway through, so I guess I just decided to do what was left for you, as SpaceSafeURI isn't very good and was still giving me trouble. This fixes all issues I had with mods such as Security Craft where the name had invalid characters such as "[" and etc, this should also fix any future issues that might arise with SpaceSafeURI.

comp500 commented 2 years ago

HttpUrl doesn't quiite work, since packwiz-installer needs to support installing from files, and in the future Git. I have nearly finished rewriting it to use PackwizPath, and switching to 4koma for deserialisation.

geferon commented 2 years ago

Oh my bad, in that case I missunderstood, I thought you were going to switch the system with HttpUrl, is there anything you need help with or something I could do to speed up the process?