Handle badly encoded URLs/special characters in paths gracefully (square brackets!)

packwiz / packwiz-installer

An installer for packwiz modpacks, with automatic auto-updating and optional mods! Works well with MultiMC and on servers.

https://packwiz.infra.link/

MIT License

54 stars 23 forks source link

Closed comp500 closed 2 years ago

comp500 commented 3 years ago

See https://github.com/comp500/packwiz-installer/issues/2#issuecomment-813106598 for the current workaround. Ideally I'd like to move to OkHttp, which has a URL class with better handling of unencoded brackets/spaces.

NathanDreamweaver commented 3 years ago

Is this going to be fixed anytime soon? It appears to be possibly the biggest bug currently around

comp500 commented 2 years ago

https://github.com/packwiz/packwiz-installer/commit/685e4c71d512f936d4c8c0a10b9010f7b2fb78c7 should fix this once it's integrated with the rest of packwiz-installer, and the targetrewrite branch is released :)