packwiz / packwiz-installer

An installer for packwiz modpacks, with automatic auto-updating and optional mods! Works well with MultiMC and on servers.
https://packwiz.infra.link/
MIT License
54 stars 23 forks source link

When changing a mod's side from server to both, existing clients don't download the mod #60

Closed object-Object closed 1 year ago

object-Object commented 1 year ago

Just as a preface, I admittedly haven't tried very hard to test this, but I'm having weird issues and I think this is what's happening. I'm using Prism Launcher 6.3 if that matters.

I had initially set a couple of mods (Chunky and Chunky Border) to server-only, then later decided I wanted them on both sides, so I changed them from side = "server" to side = "both" and did a refresh and push. When I launched the game, the mods were not in my instance's mods folder. Deleting the packwiz.json file and re-launching the pack caused it to download the new mods.

It seems like the onlyOtherSide value in packwiz.json isn't being updated when the side changes. so packwiz is ignoring the files.

Here's the faulty packwiz.json file if you want to take a look, along with a prettified version so it's readable: bad-packwiz-no-cookie.zip

Pack url if you want to test it locally: https://hexxycraft.github.io/modpack/dev/pack.toml Or this should be a permalink, since we might keep pushing changes: https://raw.githubusercontent.com/HexxyCraft/modpack/337f2166d2bf8c47a55da56efabd7f15a2abf69a/pack.toml