Open 3TUSK opened 1 year ago
Hmm.. this is interesting. A few things to note:
.properties
timestamps)such a 3-way merge would need to be done based on text
I would agree.
I feel like this behaviour is something that should be configurable
Right now, for an entry in index.toml
, we already have preserve
to control whether we want to overwrite files. I am thinking that this could be expanded to allow a new value, say merge
, which enables the merge behavior.
For files like quests, resources, we can already leave this false
to always overwrite them.
While revisiting issues discovered in our mod jam/convention event last year, I noticed this specific use-case:
foo
and go ahead to edit config on their own, i.e. their configs are nowbaz
is now disabled by default:To my knowledge, current packwiz-installer can either keep the config in scenario 3, or use the config from scenario 4, but the mod author expects this instead (syntax highlighting is JavaScript - so we can have
//
comments):In other words, the mod author wishes to do a 3-way merge for configs from scenario 2, 3 and 4.
My understanding is that, to handle 3-way merging, we actually need to have a copy of config from scenario 2, for we need to generate diff between scenario 2 and 3, and between scenario 2 and 4. This original copy does not seem available, however; user might not keep a copy of the original, and packwiz does not store the original, either.
This feature may also require the modpack to be versioned. I haven't looked into this issue in deep, so I may be wrong on this.