pacman82 / odbc-safe

A crate for writing odbc clients in safe Rust
MIT License
7 stars 4 forks source link

More type safety for Environment<V> struct #13

Closed mversic closed 4 years ago

mversic commented 4 years ago

I noticed that struct Environment<V> was previously unbounded and it was possible to create an instance of the struct(although one would have to go through some trouble to do so) with any type as version because it is of the PhantomData type.

idk if this change is preferable or it just adds to the noise even though the library is a bit more type safe with this change

adamreichold commented 4 years ago

LGTM