search

pacocoursey / cmdk

Fast, unstyled command menu React component.
https://cmdk.paco.me
MIT License
9.68k stars 279 forks source link

Fix controlled item value #109

Closed joaom00 closed 1 year ago

joaom00 commented 1 year ago

In the code it is checked if value !== undefined to call onValueChange, so when no item is selected the value is undefined making the Command uncontrolled.

Closes #106

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmdk-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 3:17pm
jeloi commented 1 year ago

@joaom00 Thank you for this fix! How can I use this version before a new release is cut / could we cut a 0.2.1 with this fix?

joaom00 commented 1 year ago

@jeloi You can clone the project and use locally

JiriTrecak commented 1 year ago

This fix is really important, is 0.2.1 coming anytime soon?