Add `data-disabled` to `Item` and recommend using data attributes

pacocoursey / cmdk

Fast, unstyled command menu React component.

https://cmdk.paco.me

MIT License

9.17k stars 262 forks source link

Closed joaom00 closed 1 year ago

joaom00 commented 1 year ago

Following what was said in #77 I believe it should also apply to aria-disabled and for consistency. This PR adds:

Add data-disabled attribute to Item part
Update docs and examples to recommend using data-attributes instead of aria-attributes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cmdk-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2023 10:33pm