fix: only scroll into view on first render and via keyboard

pacocoursey / cmdk

Fast, unstyled command menu React component.

https://cmdk.paco.me

MIT License

9.68k stars 279 forks source link

Closed joaom00 closed 8 months ago

joaom00 commented 1 year ago

Fix some issues with scroll into view when item value is changed

Scroll into view only on first render in uncontrolled/controlled mode (fixes the issue where the item is scrolled with pointer events, if controlled)
Scroll into view if defaultValue prop is provided

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cmdk-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2023 9:07pm

pyyding commented 11 months ago

Would be cool if this was merged

meyer-avest commented 11 months ago

Hello, can you merge this please? @pacocoursey