search

pacocoursey / cmdk

Fast, unstyled command menu React component.
https://cmdk.paco.me
MIT License
9.9k stars 286 forks source link

No aria-activedescendant on input #142

Closed leo-petrucci closed 1 year ago

leo-petrucci commented 1 year ago

I'm using cmdk within a Radix Popover. Looks just like the example:

https://codesandbox.io/p/sandbox/radix-dropdown-combobox-forked-j8jjph?file=%2Fsrc%2FApp.tsx%3A22%2C49

For some reason, my input doesn't seem to have an aria-activedescendant value on it, so when I use the arrow keys up and down to select different values it doesn't read them out to me.

Is this a feature we should implement ourselves? The examples on the site have the attribute so I assumed it was built in.

Is this something that broke at some point?

joaom00 commented 1 year ago

Hey @leo-petrucci,

That was fixed in #108 and will be in the next release!

leo-petrucci commented 1 year ago

Hey @leo-petrucci,

That was fixed in #108 and will be in the next release!

Thought it might be something like that! Ended up copying over the source and it worked just fine.

Thank you, I'll keep an eye on the releases!