fix: controlled search change with hidden Command.List

pacocoursey / cmdk

Fast, unstyled command menu React component.

https://cmdk.paco.me

MIT License

9.67k stars 278 forks source link

fix: controlled search change with hidden Command.List #217

Closed vltansky closed 6 months ago

vltansky commented 7 months ago

when used as combobox (Command.List as popover) manually changing input value leads to "undefined is not iterable" error cause there is no "valid items" in DOM and array.from runs on undefined. I succeded to reproduct it in Portal page and added there two buttons: hide Command.List (fake popover) and toggle search term. Wasnt sure if it should be added at Portal page or props page. Technically its not directly related to portal. Let me know if you want me to move it.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cmdk-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2024 6:25pm