search

pacocoursey / cmdk

Fast, unstyled command menu React component.
https://cmdk.paco.me
MIT License
9.04k stars 259 forks source link

Escape " (quote) in the command item text #222

Closed yjl9903 closed 4 months ago

yjl9903 commented 4 months ago

The following querySelectorAll will throw error when data-value="..." string contains " (quote)

https://github.com/pacocoursey/cmdk/blob/eb4fd0fdf39caf532bb2ae7deaa969dadb607150/cmdk/src/index.tsx#L399-L404

Maybe can encodeURI like this?

https://github.com/pacocoursey/cmdk/blob/eb4fd0fdf39caf532bb2ae7deaa969dadb607150/cmdk/src/index.tsx#L772-L777