pacocoursey / cmdk

Fast, unstyled command menu React component.
https://cmdk.paco.me
MIT License
9.02k stars 258 forks source link

Accessibility: Items not read aloud #253

Open UltimateGG opened 1 month ago

UltimateGG commented 1 month ago

At least with ChromeVox: Using arrow keys does not announce the highlighted value. https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-select-only/

I cannot figure out why, compared html to the WAI page's combobox, they look the same.

UltimateGG commented 1 month ago

The issue is value not being in the dependency array for the useMemo of selectedItemId: https://github.com/pacocoursey/cmdk/blob/13f11c4f918cb4f7eb6254b4087a9cc83928b503/cmdk/src/index.tsx#L790C1-L790C9

I'd make a pull request but there is still some problems: