Use [hidden] on group instead of changing render structure

pacocoursey / cmdk

Fast, unstyled command menu React component.

https://cmdk.paco.me

MIT License

9.56k stars 274 forks source link

Use [hidden] on group instead of changing render structure #27

Closed pacocoursey closed 2 years ago

pacocoursey commented 2 years ago

Fixes #26

I risked this change in c95c9a0 but didn't realize each item would be remounted with a new id when the group is hidden, which breaks a lot of logic that relies on each item having a stable id.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cmdk-website	✅ Ready (Inspect)	Visit Preview	Aug 9, 2022 at 8:25PM (UTC)

raunofreiberg commented 2 years ago

Very nice