search

pacocoursey / next-themes

Perfect Next.js dark mode in 2 lines of code. Support System preference and any other theme with no flashing
https://next-themes-example.vercel.app/
MIT License
4.68k stars 169 forks source link

[Feature request]: react 19 support #296

Open SuperchupuDev opened 1 month ago

SuperchupuDev commented 1 month ago

What feature would you like to see?

next.js 15 has just reached rc, and it requires react 19 (which is in rc too right now). i haven't had any issues with next-themes but npm complains about the peer dependency version of react being incorrect. as such it'd be nice if the peer dependency range was updated to allow react 19

merzainc commented 1 month ago

What feature would you like to see?

next.js 15 has just reached rc, and it requires react 19 (which is in rc too right now). i haven't had any issues with next-themes but npm complains about the peer dependency version of react being incorrect. as such it'd be nice if the peer dependency range was updated to allow react 19

I think it's good to have that but react 19 is still a beta release. Can't we wait for its release and then upgrade to the latest release.

SuperchupuDev commented 1 month ago

i'm perfectly fine with that and it sounds reasonable

mayank1513 commented 2 weeks ago

Try out https://github.com/react18-tools/nextjs-darkmode and https://github.com/react18-tools/nextjs-themes in the meantime.

pauliusuza commented 4 days ago

It would be great to revisit this, as both React and Next 15 are in RC status. Thanks