pacollins / hugo-future-imperfect-slim

Multilingual Blogging Theme for Hugo | Check the Wiki for Documentation

https://themes.gohugo.io/hugo-future-imperfect-slim/

Other

303 stars 194 forks source link

BUG: broken link highlight.js #236

Closed VincentTam closed 3 years ago

VincentTam commented 3 years ago

Bug Report

Describe the bug

The link to highlight.js is broken and it needs an update.

https://github.com/pacollins/hugo-future-imperfect-slim/blob/fa6c8c0da163dd3ea19822b017464957053f5226/layouts/partials/scripts.html#L3

https://github.com/pacollins/hugo-future-imperfect-slim/blob/2693d913cd78a8453fc263f709f5ce15e8014f23/layouts/partials/head.html#L22

To Reproduce

Enable highlightjs in config.toml.
Generate the site.
View the site in any modern web browser and open the web dev tool.
See error 404 in the Network tab in the web dev tool.

Expected behavior

No 404 error shown

Screenshots

Screenshot from 2021-03-08 12-31-01

Environment

Hugo Version: latest
Browser and Version: Opera 71
Platform: Desktop
Link to Project: https://framagit.org/VincentTam/fish-demo

Additional context

related: #218
lib on cdnjs : https://cdnjs.com/libraries/highlight.js

pacollins commented 3 years ago

@VincentTam - Did #239 not resolve this?

pacollins commented 3 years ago

Just tested locally and no longer have this error. Feel free to reopen if it is still an issue.