pacollins / hugo-future-imperfect-slim

Multilingual Blogging Theme for Hugo | Check the Wiki for Documentation
https://themes.gohugo.io/hugo-future-imperfect-slim/
Other
303 stars 194 forks source link

BUG: missing demo site's top bar translations for some languages #251

Closed VincentTam closed 3 years ago

VincentTam commented 3 years ago

Bug Report

Describe the bug

[A clear and concise description of what the bug is.]

To Reproduce

  1. Go to demo site: https://themes.gohugo.io//theme/hugo-future-imperfect-slim.
  2. Click on "EN" at the top-right corner.
  3. Select '中文(正體) zh-TW' in the pop up language menu.
  4. See error

This affects 'zh-CN' also.

Expected behavior

EN zh-TW zh-CN
Home 首頁 首页
About 關於 关于
Blog 網誌 博客
Categories 分類 分类
Contact 聯絡 联络

The conversion between Traditional Chinese :taiwan: and Simplified Chinese :cn: can be done by an online converter (say, Google Translate)—with the awareness of regional differences between the .

Screenshots

Screenshot from 2021-05-04 10-48-52

This doesn't affect other languages. The screenshot below shows that the French version of the top bar functions normally.

Screenshot from 2021-05-04 11-03-24

Environment

Additional context

The translation for each item for each language is due to an entry in config.toml. Here's an example for "Home" in French :fr:.

https://github.com/pacollins/hugo-future-imperfect-slim/blob/d2603d7e80174cc83157c03fd6af7f6ae151d80e/exampleSite/config.toml#L144-L149

https://github.com/pacollins/hugo-future-imperfect-slim/blob/d2603d7e80174cc83157c03fd6af7f6ae151d80e/exampleSite/config.toml#L263-L286

pacollins commented 3 years ago

I don't think that this is necessary. Showing English, French, and Polish is more of a "Proof of Concept" while listing the other languages shows the supported languages. Theoretically, the user will modify the menus anyway.

I'd like to know your thoughts, but if you agree we can probably close this.

VincentTam commented 3 years ago

Thank you for your response. I get your point. Lemme close this.