pacoorozco / ssham

SSH Access Manager
https://ssham.pacoorozco.info
GNU General Public License v3.0
47 stars 3 forks source link

Laravel Linter #469

Closed pacoorozco closed 7 months ago

pacoorozco commented 7 months ago

This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the shift-111694 branch.

Before merging, you need to:

Much of the lint detected may be automatically fixed by running the Laravel Fixer or tasks within the Shift Workbench.

pacoorozco commented 7 months ago

:x: The following configuration files differ from the Laravel defaults. If you are modifying configuration values directly, consider using an environment variable instead to keep these files maintainable. You should compare your configuration files against the latest version and merge any updates.

pacoorozco commented 7 months ago

:warning: The following classes do not extend the standard Laravel Model and Controller class. This may add complexity which makes your application harder to upgrade. Often a trait may be used instead of inheritance. You should review the following classes:

pacoorozco commented 7 months ago

:warning: Laravel contains many built-in helpers functions which allow you to write more expressive code or leverage core functionality from anywhere in your app.

Shift found the following code which could use a helper instead:

pacoorozco commented 7 months ago

:x: Laravel 10 added PHP type hints to all user-land code included in a new Laravel application. Shift detected these files are missing type hints. Shift recommends adding them to align with the latest Laravel conventions. You may automate this process by running the Laravel Type Hints task within Shift Workbench.

pacoorozco commented 7 months ago

:information_source: As noted, much of the lint detected above can be automatically fixed using the Laravel Fixer. Save yourself time and clean up your codebase quickly with this new Shift.