pacoorozco / ssham

SSH Access Manager
https://ssham.pacoorozco.info
GNU General Public License v3.0
47 stars 3 forks source link

PHPUnit 10 Shift #470

Closed pacoorozco closed 7 months ago

pacoorozco commented 7 months ago

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.

Before merging, you need to:

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

pacoorozco commented 7 months ago

:warning: PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

pacoorozco commented 7 months ago

:information_source: PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of void to your test cases and a return type of array to your data providers.

Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running: git revert 05ff2098

pacoorozco commented 7 months ago

:information_source: PHPUnit has documented declaring test classes as final since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as final.

Shift understands developers have different preferences when it comes to using final. If you do not wish to declare your test classes as final, you may undo this change by running: git revert 6d61ff83

pacoorozco commented 7 months ago

:warning: PHPUnit 10 now requires any base test class to have a TestCase suffix. In addition, this class should be defined as abstract. If you have a custom base test class, you should ensure it meets these new requirements.

pacoorozco commented 7 months ago

:alembic: This Shift is still being refined. Please report any issues or suggestions to shift@laravelshift.com. Your feedback is what helps improve the experience for everyone.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.58%. Comparing base (bf116be) to head (6d61ff8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #470 +/- ## ========================================= Coverage 92.58% 92.58% Complexity 355 355 ========================================= Files 94 94 Lines 1631 1631 ========================================= Hits 1510 1510 Misses 121 121 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.